Reddit reviews Carlson's Guide to Landscape Painting (Dover Art Instruction)

This is really cool! This is such essential work that will make your paintings so much better.

Here are some thoughts as I look at it:

The sky is too dark. The sky will normally be your lightest light and this one is a few shades too dark. It's almost the same value as the object in the foreground, but really should be very light sky - object a shade or two darker. You have the darkest dark in the same place I would put it, under the porch. I would actually even go darker on the back wall there.

I really like the scene because I like cityscapes a lot. One problem you are going to have here is that you don't have a very strong light source and it's hard to tell which part is in light and which part is in shadow. Because of that you are left to rely on local color for your values which can confuse things.

Take that back wall for example. I see the lighter color at the top of the wall, and I see the area where the light is hitting it. The lighter color is still in shadow, so it should be darker than the place the light hits, even though the local color is lighter.

You're not wrong and it's clear you put a lot of work and careful observation into this. Just, the value pattern can also be thought of as a light vs shadow pattern and there's not a lot of LIGHT in the photograph and that will give you problems in the value study.

here are a couple posts by stapleton kearns about value and color

http://stapletonkearns.blogspot.com/2010/07/value-color-thingy.html

http://stapletonkearns.blogspot.com/2013/10/confounding-color-and-value-in-landscape.html

edit: this book has great info on values in the landscape including how you have to compress your values because the sky is SO DAMN LIGHT it doesn't really leave a lot of room in the scale, I try to read this book about once a year because I get a little more out of it every time https://www.amazon.com/Carlsons-Guide-Landscape-Painting-Instruction-ebook/dp/B00DGBMGCA